What's wrong with this script?

[Ricky Yates]

Using ...

if (-1 = Search){

... at least spots the error.

PS: How do I generate these indented script boxes without pasting them?

[Ricky Yates]

Using ...

if (-1 = Search){

... at least spots the error.

PS: How do I generate these indented script boxes without pasting them?

[Cerise Sorbet]

Ricky.Yates wrote:

PS: How do I generate these indented script boxes without pasting them?

LL turned on source code formatting so we would scream less! It is the >> button in the edit tool bar.  It is still the most easy if you paste code from a text editor but Shift+Enter can give a line break instead of a new paragraph if you want to enter code inline.

P.S. Void I am pleasantly surprised to see you here! I hope this place can work for you!

[Void Singer]

Ricky gets a cookie, but not the prize, it should indeed be "==" instead of "=" there... good eye , but there's still more wrong here

 

ETA: @Cherise:

actually I've been here awhile in disguise, compiling a list of all the things that really need fixing... to make it actually useful... now I'm in "me" mode for reasons of documentation. PS you deserve a cookie to as spotting the code highlighting being enabled greatly ups the tolerability of this place.

[Cerise Sorbet]

Bah and double humbug, we cannot mix and match the source code and color and bold.

[Ricky Yates]

Hey, I wanted to leave something for the others, too. But since you ask ...

llDetectedKey( --Sensed );

... is looking pretty fishy, too. Does this work when 'Sensed' has a value of -1?

[Void Singer]

Actually that part is valid, although some software writers would cry bad form depending on their style guide.

you can also get away with

llDetectedKey( Sensed -= Sensed );

or even

llDetectedKey( Sensed = Sensed - 1 );

but I say why waste compile space =)

although to give it a subtle error I could have gone with

llDetectedKey( Sensed-- );

 

part of the experiment of this post is to see how much attention it recieves, how quickly, and at what level of expertise. it's not perfect though, since some will obviously ignore since I said I know...

[Paladin Pinion]

Void.Singer wrote:

part of the experiment of this post is to see how much attention it recieves, how quickly, and at what level of expertise. it's not perfect though, since some will obviously ignore since I said I know...

I only found this by accident because it happened to be at the top of the recent posts. I wouldn't have seen it otherwise. But I'm very glad you're here.

[Void Singer]

heh, guess I shouldn't be so nice as to keep posting and putting it back on top... but I have another related REAL question... at what point does a question get marked "possibly answered" ? is that in other peoples reply feedback, a matter of having awarded points for helpful, or is it just a matter of number of replies?

 

ETA:
well I know that posting back with not answered definitely changes it back... does any post to it push it into the "possibly" category? that seems kind stupid if you ask me...

[Unklebob Hotaling]

If you post a question it goes to the 'not answered' column... if someone/anyone replies it goes to 'possibly answered'... if you mark it as correct it goes to 'recently answered'... and i believe you always have the option of putting it back in the 'not answered' column as you so desire based on the replies you get.

Yes, anyone replying puts it to being 'possibly answered', it's up to you if that is indeed the case and even as 'possibly answered' it doesn't stop others from continuing to reply if they have further to add.  Same with answered, they can get replied to forever too - barring the thread being locked by a moderator.

[Lynda Klossovsky]

Had posted but deleted it till i look a bit more closely at script :>

[Void Singer]

Thanks for the clarification bob.

[Johan Laurasia]

That horid bracketing style !!!! That's what's really wrong!!!! LOL

[Void Singer]

1TBS to rule them all =)

and in this tiny viewing space? it's an absolute blessing compared to the alternatives...

so nobody? really? :: sigh ::

[Sindy Tsure]

Silly, Void.. Newbie mistakes!

edit: /me nukes her post. I spotted 5 problems with this script.

[Void Singer]

no... don't nuke it, post the solution if you've got it... there is a point to all this rigamarole...

as it stands, if I make the corrections posted here the script won't even compile... think of the poor non-compiling script!!!

[Sindy Tsure]

part of the experiment of this post is to see how much attention it recieves, how quickly, and at what level of expertise. it's not perfect though, since some will obviously ignore since I said I know...

/me nuked it because I saw this and have also wondered about such things.

[Void Singer]

but you're here, and it's only fair... if it'd been someone else would you have answered it? of course you would have. besides I'm betting no one gets a few of the non-obvious errors.

---

[Lylani Bellic]

integer  Range     = 40;

float    Arc       = 2 * PI;

float    Frequency = 10.0;

list     Previous;

key      Target;

 

default

{     state_entry()

     {          llSensorRepeat( "", "", AGENT, Range, Arc, Frequency );     }     sensor( integer Sensed )

     {          do

          {

               Target = llDetectedKey( --Sensed );

               if (llListFindList(Previous, Target) == -1){

                    Previous += ;

                    llDialog( Target, "Message ", [], -42 );               }          }while (Sensed)     }}

 

That's what I found to change.  I havn't tried it in a compiler so no clue if it'd work But it looks fine to me.

Personally I would do the sensor event differently to begin with but that's just a matter of style as was the change I made of removing the need for the "Search" integer.

[Void Singer]

not bad, still doesn't compile though =)

the type change on "Target" is one of the subtle (but not harmful) errors...

I still count two compile errors

---

[IttyBittyKitty Littlepaws]

um... i could be WAY off here, since i'm not in-world or at a compiler to test, but here's two things i see:

1. range should be a float, not integer

2. the button list cannot be empty in the llDialog call

Please let me know if i'm wrong

[Unklebob Hotaling]

my pleasure   -bows-

[Void Singer]

check on the float (it won't prevent compile, compiler inserts a cast int the sensor repeat event)

though actually you can use an empty button list, and the viewer will insert an "OK" button.

still doesn't compile...

"oh won't someone please help newbie me fix this script?"

---

[IttyBittyKitty Littlepaws]

Ok, I found something else, that I'm certain causes a failure, because i keep forgetting this myself LOL

Hope this is PART of the answer:P

Search = llListFindList( Previous, Target );

shouldn't this be:

Search = llListFindList( Previous, );

[Johan Laurasia]

float    Arc       = 2 * PI;

// should be

float    Arc       = TWO_PI   

[Void Singer]

yup that's part of it, still not compiling though... oh woe is me...=)

ETA:
I really need to remember to ad that horizontal rule at the bottom...

ETA2:
still not compiling Johan... what on earth could it be....

---